feat: option to not read size of blocks for want-have requests #672
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 60.29% 60.33% +0.03%
==========================================
Files 243 243
Lines 30889 30953 +64
==========================================
+ Hits 18624 18674 +50
- Misses 10603 10620 +17
+ Partials 1662 1659 -3
|
|
See configuration in kubo: ipfs/kubo#10512 |
gammazero
changed the title
|
I tested this E2E, and things have been going smoothly so far. Will see how it works over the weekend. |
|
The cluster performs correctly, and the nodes are still in sync. We haven't tested for performance improvements or degradations and I think that's an approve from our side. |
bare minimum to make it possible to discover current implicit default by reading godocs
lidel
changed the title
There was a problem hiding this comment.
lgtm, pushed cosmetic docs changes (godoc explaining feature bit more + ability to read implicit default via godoc)
@gammazero thanks again, if text looks good to you, free to squash and merge 🚀
Allow configuration of the bitswap server's replace WantHave with WantBlock maximum block size using the Internal.Bitswap.WantHaveReplaceSize config item. This sets the maximum size of a block in bytes up to which we will replace a want-have with a want-block. Setting a size of 0 disables this replacement and means that block sizes are not read for WantHave requests. See ipfs/boxo#672 for more details Updated boxo to version with PR 672 --------- Co-authored-by: Marcin Rataj <lidel@lidel.org>
When the replace-have-with-want-blocks is disabled, the block sizes for blocks corresponding to have-want requests are not read and instead the blockstore is checked only to see if the block is present.
The replace-have-with-want-blocks feature can be disabled using the new
WithReplaceHasWithBlockMaxSize(n)option which can be used withbitswap.New. It sets the maximum size of a block in bytes up to which we will replace a want-have with a want-block. Setting a size of 0 disables want-have replacement and means that block sizes are not read for want-have requests.Aims to fix #657